DNS service discovery #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalszynkiewicz
changed the title
cescoffier
requested changes
Jul 8, 2022
service-discovery/dns/src/main/java/io/smallrye/stork/servicediscovery/dns/DnsMetadataKey.java
Outdated
Show resolved
Hide resolved
service-discovery/dns/src/main/java/io/smallrye/stork/servicediscovery/dns/DnsMetadataKey.java
Outdated
Show resolved
Hide resolved
...ry/dns/src/main/java/io/smallrye/stork/servicediscovery/dns/DnsServiceDiscoveryProvider.java
Outdated
Show resolved
Hide resolved
|
after a bit of thought I started wondering if going purely with UDP to talk with the DNS server is not a better option. |
|
Isn't DNS over UDP still a bit young? |
|
From what I read while working on this, DNS is primarily over UDP, with fallback to TCP |
|
Even on cloud providers? That's my concern. On the Cloud, UDP is not working great (most of the time) |
|
Good point, I'll convert this PR to draft then, I think the vertx resolver that I'm using by default does UDP. |
aureamunoz
requested changes
Jul 8, 2022
...-discovery/dns/src/main/java/io/smallrye/stork/servicediscovery/dns/DnsServiceDiscovery.java
Outdated
Show resolved
Hide resolved
...-discovery/dns/src/main/java/io/smallrye/stork/servicediscovery/dns/DnsServiceDiscovery.java
Outdated
Show resolved
Hide resolved
michalszynkiewicz
force-pushed
the
dns-sd
branch
3 times, most recently
from
cd9375b
to
d580544
Compare
cescoffier
requested changes
Jul 18, 2022
core/src/main/java/io/smallrye/stork/impl/CachingServiceDiscovery.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/smallrye/stork/utils/StorkAddressUtils.java
Outdated
Show resolved
Hide resolved
michalszynkiewicz
force-pushed
the
dns-sd
branch
from
d580544
to
90b5d63
Compare
michalszynkiewicz
force-pushed
the
dns-sd
branch
from
90b5d63
to
2d378c7
Compare
cescoffier
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #86
refs quarkusio/quarkus#26409